Skip to content

Conversation

@ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 23, 2023

Description

Test failure message when executing register_table procedure in Iceberg REST and JDBC catalogs

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Jan 23, 2023
@cla-bot cla-bot bot added the cla-signed label Jan 23, 2023
Copy link
Contributor

@krvikash krvikash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ebyhr added 2 commits January 25, 2023 08:52
Previously, the procedure threw the below message.
Cannot invoke "org.apache.iceberg.util.SerializableSupplier.get()" because "this.hadoopConf" is null
@ebyhr ebyhr force-pushed the ebi/iceberg-register-tables branch from 2a7f165 to 96606a2 Compare January 24, 2023 23:53
@ebyhr ebyhr requested review from alexjo2144 and findepi January 25, 2023 02:35
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let @alexjo2144 review as well

Copy link
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a follow-up issue to fix the error the Iceberg code is throwing?

@ebyhr
Copy link
Member Author

ebyhr commented Jan 25, 2023

Filed "Add support for register_table and unregister_table procedures in Iceberg REST and JDBC catalogs" #15853

@ebyhr ebyhr merged commit a249aa6 into trinodb:master Jan 26, 2023
@ebyhr ebyhr deleted the ebi/iceberg-register-tables branch January 26, 2023 04:44
@github-actions github-actions bot added this to the 407 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants