Skip to content

Randomize table names in MongoDB tests #15747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 4 commits into from
Feb 5, 2023
Merged

Randomize table names in MongoDB tests #15747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ff739b
Create resources with random suffix in mongodb tests
mayankvadariya Jan 27, 2023
38064b3
Cleanup test resources
mayankvadariya Jan 27, 2023
5a0e707
Consider system.views as system table in mongodb
mayankvadariya Jan 27, 2023
766059e
Filter the system schemas in mongodb
mayankvadariya Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@
public class MongoSession
{
private static final Logger log = Logger.get(MongoSession.class);
private static final List<String> SYSTEM_TABLES = Arrays.asList("system.indexes", "system.users", "system.version");
private static final Set<String> SYSTEM_DATABASES = Set.of("admin", "local", "config");
private static final List<String> SYSTEM_TABLES = Arrays.asList("system.indexes", "system.users", "system.version", "system.views");

private static final String TABLE_NAME_KEY = "table";
private static final String COMMENT_KEY = "comment";
Expand Down Expand Up @@ -187,7 +188,10 @@ public List<HostAddress> getAddresses()

public List<String> getAllSchemas()
{
return ImmutableList.copyOf(listDatabaseNames().map(name -> name.toLowerCase(ENGLISH)));
return Streams.stream(listDatabaseNames())
.filter(schema -> !SYSTEM_DATABASES.contains(schema))
.map(schema -> schema.toLowerCase(ENGLISH))
.collect(toImmutableList());
}

public void createSchema(String schemaName)
Expand Down Expand Up @@ -865,6 +869,9 @@ private String toRemoteSchemaName(String schemaName)
if (!caseInsensitiveNameMatching) {
return schemaName;
}
if (SYSTEM_DATABASES.contains(schemaName)) {
return schemaName;
}
for (String remoteSchemaName : listDatabaseNames()) {
if (schemaName.equals(remoteSchemaName.toLowerCase(ENGLISH))) {
return remoteSchemaName;
Expand Down
Loading