Randomize table names in MongoDB tests #15747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
mayankvadariya
force-pushed
the
mayankv/clean-resources-in-mongodb-tests
branch
2 times, most recently
from
0a54423 to
0cb8f22
Compare
Member
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
anusudarsan
reviewed
Jan 26, 2023
Member
There was a problem hiding this comment.
commit title should be something like Randomize table names in MongoDB tests and squash both commits
mayankvadariya
force-pushed
the
mayankv/clean-resources-in-mongodb-tests
branch
from
0cb8f22 to
a656e57
Compare
anusudarsan
approved these changes
Feb 3, 2023
Member
anusudarsan
left a comment
anusudarsan
left a comment
There was a problem hiding this comment.
LGTM % all commit titles are updated to indicate better that its for mongodb connector
mayankvadariya
force-pushed
the
mayankv/clean-resources-in-mongodb-tests
branch
2 times, most recently
from
084f74c to
1a3bdf5
Compare
ebyhr
approved these changes
Feb 3, 2023
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
mayankvadariya
force-pushed
the
mayankv/clean-resources-in-mongodb-tests
branch
from
1a3bdf5 to
7ea4373
Compare
ebyhr
reviewed
Feb 4, 2023
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
system.views is not queryable collection
mayankvadariya
force-pushed
the
mayankv/clean-resources-in-mongodb-tests
branch
from
7ea4373 to
766059e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.