Skip to content

[WIP]: Fix drop void partition column in iceberg connector #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krvikash wants to merge 1 commit into from
Closed

[WIP]: Fix drop void partition column in iceberg connector #15740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1530,12 +1530,17 @@ public void dropColumn(ConnectorSession session, ConnectorTableHandle tableHandl
{
IcebergColumnHandle handle = (IcebergColumnHandle) column;
Table icebergTable = catalog.loadTable(session, ((IcebergTableHandle) tableHandle).getSchemaTableName());
boolean isPartitionColumn = icebergTable.spec().fields().stream()
.anyMatch(field -> field.sourceId() == handle.getId() && !isVoidTransform(field));
if (isPartitionColumn) {
Optional<PartitionField> partitionField = icebergTable.spec().fields().stream()
.filter(field -> field.sourceId() == handle.getId()).findAny();
if (partitionField.isPresent() && !isVoidTransform(partitionField.get())) {
throw new TrinoException(NOT_SUPPORTED, "Cannot drop partition field: " + handle.getName());
}
try {
if (partitionField.isPresent()) {
icebergTable.updateSpec()
.removeField(partitionField.get().name())
.commit();
}
icebergTable.updateSchema()
.deleteColumn(handle.getName())
.commit();
Expand Down
10 changes: 10 additions & 0 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,6 +1185,16 @@ public void testAddNotNullColumnToNonEmptyTable()
}
}

@Test
public void tesInsertAfterDropVoidPartitionColumn()
{
String tableName = "test_drop_partition_column_" + randomNameSuffix();
assertUpdate("CREATE TABLE " + tableName + " (id INTEGER, name VARCHAR) WITH (partitioning = ARRAY['id', 'void(name)'])");
assertUpdate("ALTER TABLE " + tableName + " DROP COLUMN name");
assertUpdate("INSERT INTO " + tableName + " VALUES (1)", 1);
dropTable(tableName);
}

@Test
public void testSchemaEvolution()
{
Expand Down