[WIP]: Fix drop void partition column in iceberg connector#15740
Closed
krvikash wants to merge 1 commit intotrinodb:masterfrom
Closed
[WIP]: Fix drop void partition column in iceberg connector#15740krvikash wants to merge 1 commit intotrinodb:masterfrom
krvikash wants to merge 1 commit intotrinodb:masterfrom
Conversation
Contributor
Author
|
CI Failure: #15729 needs to be fixed. |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Member
|
@krvikash are you still working on this? If you want someone to take a look, you'll need to fix conflicts and remove the WIP. If you need more time to work on this, we may just close this and you can reopen it when you have time to work on it. Let me know. |
Contributor
Author
|
Hi @bitsondatadev, This PR depends on #15729 which further depends on apache/iceberg#4602. I am waiting for a fix from Iceberg. |
Member
|
Let's close this until it's ready to be worked on. You can reopen this same one once the blockers are removed, we just want to only keep active non-blocked PRs open. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IcebergMetadata#dropColumndoes not remove the partition column from the current partition spec. which causes the failure when trying to select/insert/update on the table.Partial fixes #15738
This PR depends on #15729 to get fixed completely.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: