Skip to content

Update title of container docs to mention Docker #15638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Feb 6, 2023
Merged

Update title of container docs to mention Docker #15638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions docs/src/main/sphinx/installation/containers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
===================
Trino in containers
===================
===========================
Trino in a Docker container
===========================

The Trino project provides the `trinodb/trino <https://hub.docker.com/r/trinodb/trino>`_
Docker image that includes the Trino server and a default configuration.
Docker image that includes the Trino server and a default configuration. The
Docker image is published to Docker Hub and can be used with the Docker runtime,
among several others.
Comment on lines +7 to +8
Copy link
Member

@findepi findepi Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we're adding this sentence. Why not just update the title?

We don't need to specify with runtimes run docker images, just like we don't really define what "a docker image" is.

Copy link
Member Author

@colebow colebow Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to be clear that this isn't the only way to do things / you don't have to follow this guide.

Copy link
Member

@mosabua mosabua Feb 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is helpful and clarifying and does not do any harm. I would leave as is and merge. Specifically also since the new title narrows the scope .. and is kind of misleading therefore, this sentence clarifies.


Running the container
---------------------
Expand Down