-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update title of container docs to mention Docker #15638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update title of container docs to mention Docker #15638
Conversation
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. We could optionally update the initial paragraph to say that it is suitable for kubernetes and refer to the helm chart docs page as well
nineinchnick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker is not the only runtime that can be used to run Trino in a container. We do publish a Docker image to Docker Hub thought.
|
@nineinchnick @colebow and @findepi .. I think we should add a sentence to the intro paragraph that says that:
Let's do that all in this PR since we are already on it.. |
I'm going to keep the edits minimal because of a section slightly lower down: |
14a0b49 to
d73542d
Compare
Fair |
d73542d to
b76ccb9
Compare
b76ccb9 to
411a833
Compare
| Docker image is published to Docker Hub and can be used with the Docker runtime, | ||
| among several others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we're adding this sentence. Why not just update the title?
We don't need to specify with runtimes run docker images, just like we don't really define what "a docker image" is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to be clear that this isn't the only way to do things / you don't have to follow this guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is helpful and clarifying and does not do any harm. I would leave as is and merge. Specifically also since the new title narrows the scope .. and is kind of misleading therefore, this sentence clarifies.
|
Thank you @findepi ! |
Description
So that when you search for pages that mention Docker, you end up in the right place.
Additional context and related issues
From this thread on the Trino slack: https://trinodb.slack.com/archives/CP1MUNEUX/p1672858775220719
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: