Skip to content

Attempt to upload heap dump if tests failed #15129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineinchnick wants to merge 2 commits into from
Closed

Attempt to upload heap dump if tests failed #15129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7230b64
In CI run the upload action even on failures
Nov 23, 2022
ded3ab3
Attempt to upload heap dump if tests failed
Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions .github/actions/upload/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,44 @@
name: upload
description: "Upload test results"
description: "Upload test results, reports, and heap dump."
inputs:
name-suffix:
default: ${{ github.job }}
upload-results:
default: false
upload-heap-dump:
default: false
test-report-retention-days:
default: 5
heap-dump-retention-days:
default: 14
Comment thread
findepi marked this conversation as resolved.
Outdated

runs:
using: composite
steps:
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
if: failure()
if: always() && inputs.upload-results
with:
name: result ${{ inputs.name-suffix }}
if-no-files-found: 'ignore'
Comment thread
nineinchnick marked this conversation as resolved.
Outdated
path: |
**/target/surefire-reports
**/target/checkstyle-*
- name: Upload test report
uses: actions/upload-artifact@v3
# Always upload the test report for the annotate.yml workflow,
# but only the single XML file to keep the artifact small
if: always()
Comment thread
hashhar marked this conversation as resolved.
Outdated
with:
# Name prefix is checked in the `Annotate checks` workflow
name: test report ${{ inputs.name-suffix }}
path: |
**/surefire-reports/TEST-*.xml
retention-days: ${{ inputs.test-report-retention-days }}
- name: Upload heap dump
uses: actions/upload-artifact@v3
if: always() && inputs.upload-heap-dump
with:
name: heap dump ${{ github.job }}
if-no-files-found: 'ignore'
path: |
**/*.hprof
Comment thread
findepi marked this conversation as resolved.
Outdated
retention-days: ${{ inputs.heap-dump-retention-days }}
62 changes: 60 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,18 +163,26 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY $MAVEN clean install ${MAVEN_FAST_INSTALL} ${MAVEN_GIB} -Dgib.logImpactedTo=gib-impacted.log -pl '!:trino-docs,!:trino-server,!:trino-server-rpm'
- name: Test old JDBC vs current server
id: test-old
run: |
if [ ! -f gib-impacted.log ] || grep -q testing/trino-test-jdbc-compatibility-old-driver gib-impacted.log; then
testing/trino-test-jdbc-compatibility-old-driver/bin/run_tests.sh
fi
- name: Test current JDBC vs old server
id: test-new
if: always()
run: |
if [ ! -f gib-impacted.log ] || grep -q testing/trino-test-jdbc-compatibility-old-server gib-impacted.log; then
$MAVEN test ${MAVEN_TEST} -pl :trino-test-jdbc-compatibility-old-server
fi
- uses: ./.github/actions/upload
# Always upload the test report for the annotate.yml workflow, but only the single XML file to keep the artifact small
if: always()
with:
# Upload all test reports only on failure, because the artifacts are large
upload-results: ${{ steps.test-old.conclusion == 'failure' || steps.test-new.conclusion == 'failure' }}
# only upload heap dumps if running on forks, where no secrets are used
upload-heap-dump: ${{ secrets.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository }}
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
Expand All @@ -200,10 +208,12 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY $MAVEN clean install ${MAVEN_FAST_INSTALL} ${MAVEN_GIB} -Dgib.logImpactedTo=gib-impacted.log -am -pl :trino-hive-hadoop2
- name: Run Hive Tests
id: test-hive
run: |
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_tests.sh
- name: Run Hive S3 Tests
id: test-s3
env:
AWS_ACCESS_KEY_ID: ${{ secrets.TRINO_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.TRINO_AWS_SECRET_ACCESS_KEY }}
Expand All @@ -219,6 +229,7 @@ jobs:
fi
fi
- name: Run Hive Glue Tests
id: test-glue
env:
AWS_ACCESS_KEY_ID: ${{ secrets.TRINO_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.TRINO_AWS_SECRET_ACCESS_KEY }}
Expand All @@ -228,6 +239,7 @@ jobs:
$MAVEN test ${MAVEN_TEST} -pl :trino-hive -P test-hive-glue
fi
- name: Run Hive Azure ABFS Access Key Tests
id: test-abfs-access-key
if: matrix.config != 'config-empty' # Hive 1.x does not support Azure storage
env:
ABFS_CONTAINER: ${{ secrets.AZURE_ABFS_CONTAINER }}
Expand All @@ -239,6 +251,7 @@ jobs:
plugin/trino-hive-hadoop2/bin/run_hive_abfs_access_key_tests.sh
fi
- name: Run Hive Azure ABFS OAuth Tests
id: test-abfs-oauth
if: matrix.config != 'config-empty' # Hive 1.x does not support Azure storage
env:
ABFS_CONTAINER: ${{ secrets.AZURE_ABFS_CONTAINER }}
Expand All @@ -252,6 +265,7 @@ jobs:
plugin/trino-hive-hadoop2/bin/run_hive_abfs_oauth_tests.sh
fi
- name: Run Hive Azure WASB Tests
id: test-abfs-wasb
if: matrix.config != 'config-empty' # Hive 1.x does not support Azure storage
env:
WASB_CONTAINER: ${{ secrets.AZURE_WASB_CONTAINER }}
Expand All @@ -263,6 +277,7 @@ jobs:
plugin/trino-hive-hadoop2/bin/run_hive_wasb_tests.sh
fi
- name: Run Hive Azure ADL Tests
id: test-abfs-adl
if: matrix.config != 'config-empty' # Hive 1.x does not support Azure storage
env:
ADL_NAME: ${{ secrets.AZURE_ADL_NAME }}
Expand All @@ -275,12 +290,27 @@ jobs:
plugin/trino-hive-hadoop2/bin/run_hive_adl_tests.sh
fi
- name: Run Hive Alluxio Tests
id: test-alluxio
run: |
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
- uses: ./.github/actions/upload
# Always upload the test report for the annotate.yml workflow, but only the single XML file to keep the artifact small
if: always()
with:
name-suffix: ${{ github.job }} (${{ matrix.config }})
# Upload all test reports only on failure, because the artifacts are large
upload-results: >-
${{ steps.test-hive.conclusion == 'failure' ||
steps.test-s3.conclusion == 'failure' ||
steps.test-glue.conclusion == 'failure' ||
steps.test-abfs-access-key.conclusion == 'failure' ||
steps.test-abfs-oauth.conclusion == 'failure' ||
steps.test-abfs-wasb.conclusion == 'failure' ||
steps.test-abfs-adl.conclusion == 'failure' ||
steps.test-alluxio.conclusion == 'failure' }}
# only upload heap dumps if running on forks, where no secrets are used
upload-heap-dump: ${{ secrets.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository }}
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
Expand All @@ -300,6 +330,7 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY $MAVEN clean install ${MAVEN_FAST_INSTALL} ${MAVEN_GIB} -pl '!:trino-docs,!:trino-server,!:trino-server-rpm'
- name: Maven Tests
id: test
run: |
$MAVEN test ${MAVEN_TEST} -pl '
!:trino-accumulo,
Expand Down Expand Up @@ -332,7 +363,13 @@ jobs:
!:trino-test-jdbc-compatibility-old-server,
!:trino-tests'
- uses: ./.github/actions/upload
# Always upload the test report for the annotate.yml workflow, but only the single XML file to keep the artifact small
if: always()
with:
# Upload all test reports only on failure, because the artifacts are large
upload-results: ${{ steps.test.conclusion == 'failure' }}
# only upload heap dumps if running on forks, where no secrets are used
upload-heap-dump: ${{ secrets.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository }}
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
Expand Down Expand Up @@ -426,13 +463,15 @@ jobs:
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
$RETRY $MAVEN clean install ${MAVEN_FAST_INSTALL} ${MAVEN_GIB} -am -pl "${{ matrix.modules }}"
- name: Maven Tests
id: test
if: >-
matrix.modules != 'plugin/trino-singlestore' &&
!((contains(matrix.modules, 'trino-delta-lake') && (contains(matrix.profile, 'cloud-tests') || contains(matrix.profile, 'gcs-tests'))) || (contains(matrix.modules, 'trino-iceberg') && contains(matrix.profile, 'cloud-tests')))
run: $MAVEN test ${MAVEN_TEST} -pl ${{ matrix.modules }} ${{ matrix.profile != '' && format('-P {0}', matrix.profile) || '' }}
# Additional tests for selected modules
- name: Cloud Delta Lake Tests
# Cloud tests are separate because they are time intensive, requiring cross-cloud network communication
id: test-cloud-delta
# Cloud tests are separate because they are time intensive, requiring cross-cloud network communication
env:
ABFS_CONTAINER: ${{ secrets.AZURE_ABFS_CONTAINER }}
ABFS_ACCOUNT: ${{ secrets.AZURE_ABFS_ACCOUNT }}
Expand All @@ -450,7 +489,8 @@ jobs:
-Dhive.hadoop2.azure-abfs-account="${ABFS_ACCOUNT}" \
-Dhive.hadoop2.azure-abfs-access-key="${ABFS_ACCESSKEY}"
- name: GCS Delta Lake Tests
# Cloud tests are separate because they are time intensive, requiring cross-cloud network communication
id: test-gcs-delta
# Cloud tests are separate because they are time intensive, requiring cross-cloud network communication
env:
GCP_CREDENTIALS_KEY: ${{ secrets.GCP_CREDENTIALS_KEY }}
# Run tests if any of the secrets is present. Do not skip tests when one secret renamed, or secret name has a typo.
Expand All @@ -461,12 +501,14 @@ jobs:
-Dtesting.gcp-storage-bucket="trino-ci-test" \
-Dtesting.gcp-credentials-key="${GCP_CREDENTIALS_KEY}"
- name: Memsql Tests
id: test-memsql
env:
MEMSQL_LICENSE: ${{ secrets.MEMSQL_LICENSE }}
if: matrix.modules == 'plugin/trino-singlestore' && env.MEMSQL_LICENSE != ''
run: |
$MAVEN test ${MAVEN_TEST} -pl :trino-singlestore -Dmemsql.license=${MEMSQL_LICENSE}
- name: Cloud BigQuery Tests
id: test-cloud-bigquery
env:
BIGQUERY_CREDENTIALS_KEY: ${{ secrets.BIGQUERY_CREDENTIALS_KEY }}
if: matrix.modules == 'plugin/trino-bigquery' && env.BIGQUERY_CREDENTIALS_KEY != ''
Expand All @@ -476,12 +518,14 @@ jobs:
-Dtesting.gcp-storage-bucket="trino-ci-test" \
-Dtesting.alternate-bq-project-id=bigquery-cicd-alternate
- name: Cloud BigQuery Case Insensitive Mapping Tests
id: test-cloud-bigquery-mapping
env:
BIGQUERY_CASE_INSENSITIVE_CREDENTIALS_KEY: ${{ secrets.BIGQUERY_CASE_INSENSITIVE_CREDENTIALS_KEY }}
if: matrix.modules == 'plugin/trino-bigquery' && env.BIGQUERY_CASE_INSENSITIVE_CREDENTIALS_KEY != ''
run: |
$MAVEN test ${MAVEN_TEST} -pl :trino-bigquery -Pcloud-tests-case-insensitive-mapping -Dbigquery.credentials-key="${BIGQUERY_CASE_INSENSITIVE_CREDENTIALS_KEY}"
- name: Iceberg Cloud Tests
id: test-cloud-iceberg
env:
AWS_ACCESS_KEY_ID: ${{ secrets.TRINO_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.TRINO_AWS_SECRET_ACCESS_KEY }}
Expand All @@ -505,8 +549,21 @@ jobs:
name=$(echo -n "${{ matrix.modules }}" | sed -e 's/[":<>|\*\?\\\/]/_/g')
echo "ARTIFACT_NAME=$name" >> $GITHUB_ENV
- uses: ./.github/actions/upload
# Always upload the test report for the annotate.yml workflow, but only the single XML file to keep the artifact small
if: always()
with:
name-suffix: ${{ env.ARTIFACT_NAME }}
# Upload all test reports only on failure, because the artifacts are large
upload-results: >-
${{ steps.test.conclusion == 'failure' ||
Comment thread
nineinchnick marked this conversation as resolved.
steps.test-cloud-delta.conclusion == 'failure' ||
steps.test-gcs-delta.conclusion == 'failure' ||
steps.test-memsql.conclusion == 'failure' ||
steps.test-cloud-bigquery.conclusion == 'failure' ||
steps.test-cloud-bigquery-mapping.conclusion == 'failure' ||
steps.test-cloud-iceberg.conclusion == 'failure' }}
# only upload heap dumps if running on forks, where no secrets are used
upload-heap-dump: ${{ secrets.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository }}
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
Expand Down Expand Up @@ -798,6 +855,7 @@ jobs:
if: failure()
with:
name: result pt (${{ matrix.config }}, ${{ matrix.suite }}, ${{ matrix.jdk }})
if-no-files-found: 'ignore'
path: |
testing/trino-product-tests/target/*
logs/*
Expand Down