Attempt to upload heap dump if tests failed#15129
Closed
nineinchnick wants to merge 2 commits intotrinodb:masterfrom
Closed
Attempt to upload heap dump if tests failed#15129nineinchnick wants to merge 2 commits intotrinodb:masterfrom
nineinchnick wants to merge 2 commits intotrinodb:masterfrom
Conversation
nineinchnick
commented
Nov 21, 2022
hashhar
reviewed
Nov 21, 2022
nineinchnick
force-pushed
the
heap-dumps
branch
from
666805a to
451aa2b
Compare
findepi
reviewed
Nov 22, 2022
findepi
approved these changes
Nov 22, 2022
hashhar
approved these changes
Nov 22, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % verification the condition actually works as expected
nineinchnick
force-pushed
the
heap-dumps
branch
4 times, most recently
from
1e0ae1e to
a82a3ec
Compare
nineinchnick
force-pushed
the
heap-dumps
branch
4 times, most recently
from
4d292d5 to
db13198
Compare
hashhar
reviewed
Nov 24, 2022
added 2 commits
November 24, 2022 11:48
Always run the upload action to save the test report, but don't attempt to upload test results unless tests failed to avoid generating many warning annotations about missing files.
nineinchnick
force-pushed
the
heap-dumps
branch
from
db13198 to
ded3ab3
Compare
nineinchnick
commented
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is supposed to help debug OOM errors that happen in the CI.
Was partially discussed in #14865
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: