Reuse short Char and Varchar type instances#14911
Merged
findepi merged 3 commits intotrinodb:masterfrom Nov 9, 2022
Merged
Conversation
findepi
added
the
no-release-notes
losipiuk
approved these changes
Nov 4, 2022
ebyhr
approved these changes
Nov 6, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Looks good except for CI failure.
Error: TestStringFunctions.testCharConcat:959->AbstractTestFunctions.assertInvalidFunction:124
Expecting:
<TYPE_NOT_FOUND:43>
to be in:
<[INVALID_FUNCTION_ARGUMENT:7]>
3d72d60 to
f8c0369
Compare
Member
Author
|
Hopefully fixed |
Member
Author
|
CI #14248 |
`TrinoException` is not appropriate there. It's higher level code's responsibility to raise the proper `TrinoException`.
Replace `createCharType(long)` with `createCharType(int)`. `int` is very well sufficient and also this is compatible with `VarcharType.createVarcharType(int)`.
Share ("cache") instances for short `char` and `varchar` types.
- type instantiation can be expensive (see
96a009e)
- it allows caching things further, like in `getRange()`.
findepi
force-pushed
the
findepi/cachcar
branch
from
f8c0369 to
ccab7db
Compare
Member
Author
|
(just rebased to resolve conflicts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Share ("cache") instances for short
charandvarchartypes.96a009e, Cache short decimal type instances #14523)
getRange()(see Cache VarcharType.getRange #14910, Implement CharType.getRange #14912)