Minor cleanups and improvements to FileSystemExchange#14806
Merged
losipiuk merged 3 commits intotrinodb:masterfrom Oct 29, 2022
Merged
Minor cleanups and improvements to FileSystemExchange#14806losipiuk merged 3 commits intotrinodb:masterfrom
losipiuk merged 3 commits intotrinodb:masterfrom
Conversation
arhimondr
approved these changes
Oct 27, 2022
losipiuk
reviewed
Oct 28, 2022
Member
There was a problem hiding this comment.
what does it change really? Isn't exception caught up the stack anyway and handle same way?
We are throwing in line 52 and this one is no different, right?
Member
Author
There was a problem hiding this comment.
Thanks for pointing out, updating line 52 too.
Member
There was a problem hiding this comment.
But still:
what does it change really?
Member
There was a problem hiding this comment.
Actually yeah - that way we may collect more than one error.
Member
Author
There was a problem hiding this comment.
I tested and just realized that it doesn't make much of a difference in terms of error surfacing. Added return under line 52. I'm fine both ways.
linzebing
force-pushed
the
spooling-cleanup
branch
from
f4d793a to
efe12ad
Compare
losipiuk
approved these changes
Oct 28, 2022
losipiuk
reviewed
Oct 28, 2022
...e-filesystem/src/main/java/io/trino/plugin/exchange/filesystem/FileSystemExchangeModule.java
Outdated
Show resolved
Hide resolved
linzebing
force-pushed
the
spooling-cleanup
branch
from
efe12ad to
43d1802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove redundancy, change misleading config example and improve error surfacing on bootstrap.
Non-technical explanation
As above.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: