Skip to content

Change dictionary source ID when dictionary block is unwrapped #14305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dain merged 1 commit into from
Sep 27, 2022
Merged

Change dictionary source ID when dictionary block is unwrapped #14305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/trino-spi/src/main/java/io/trino/spi/block/DictionaryBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ private static Block createInternal(int positionCount, Block dictionary, int[] i
newIds[position] = dictionaryBlock.getId(ids[position]);
}
dictionary = dictionaryBlock.getDictionary();
dictionarySourceId = dictionaryBlock.getDictionarySourceId();
Copy link
Copy Markdown
Member

@sopel39 sopel39 Sep 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still wrong. Consider two blocks with nested dictionaries:

topN:
  sourceId: A
  ids: [0, 2, 2]
    nestedY:
      source: 1
      ids: [1, 2, 3]
      block: X

topM:
   sourceId: B
   ids: [0, 1]
   nestedV:
      source: 1
      ids: [1, 2, 3]
      block: Y

You cannot make them

topM':
   sourceId: 1
   ids: [1, 3, 3]
   block: X

topN':
   sourceId: 1
   ids: [1, 2]
   block: Y

topM', topN' cannot have same source ids as topM'.ids != topN'.ids. Even if ids were same, they might have originated from different source and just coincidentally be same

ids = newIds;
}
return new DictionaryBlock(0, positionCount, dictionary, ids, false, false, dictionarySourceId);
Expand Down