Change dictionary source ID when dictionary block is unwrapped#14305
Merged
dain merged 1 commit intotrinodb:masterfrom Sep 27, 2022
Merged
Change dictionary source ID when dictionary block is unwrapped#14305dain merged 1 commit intotrinodb:masterfrom
dain merged 1 commit intotrinodb:masterfrom
Conversation
martint
reviewed
Sep 27, 2022
core/trino-spi/src/main/java/io/trino/spi/block/DictionaryBlock.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
dictionary-block-fix
branch
from
f4a20b2 to
59245c8
Compare
martint
approved these changes
Sep 27, 2022
sopel39
reviewed
Sep 28, 2022
| newIds[position] = dictionaryBlock.getId(ids[position]); | ||
| } | ||
| dictionary = dictionaryBlock.getDictionary(); | ||
| dictionarySourceId = dictionaryBlock.getDictionarySourceId(); |
Member
There was a problem hiding this comment.
it's still wrong. Consider two blocks with nested dictionaries:
topN:
sourceId: A
ids: [0, 2, 2]
nestedY:
source: 1
ids: [1, 2, 3]
block: X
topM:
sourceId: B
ids: [0, 1]
nestedV:
source: 1
ids: [1, 2, 3]
block: Y
You cannot make them
topM':
sourceId: 1
ids: [1, 3, 3]
block: X
topN':
sourceId: 1
ids: [1, 2]
block: Y
topM', topN' cannot have same source ids as topM'.ids != topN'.ids. Even if ids were same, they might have originated from different source and just coincidentally be same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: