Skip to content

Fix delete, truncate behavior in BaseJdbcConnectorTest #14251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Praveen2112 merged 1 commit into from
Sep 22, 2022
Merged

Fix delete, truncate behavior in BaseJdbcConnectorTest #14251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
switch (connectorBehavior) {
case SUPPORTS_DELETE:
case SUPPORTS_TRUNCATE:
return true;
Copy link
Copy Markdown
Member Author

@Praveen2112 Praveen2112 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it inter-related for any reason ?

Copy link
Copy Markdown
Member

@hashhar hashhar Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logical mistake in https://github.com/trinodb/trino/pull/13334/files#diff-6d69520925faa8f876d78d002c7ad94202dfc4a81a9758a5bc3f2ba93b40e023R128

One more reason in favour of @findepi's idea to keep only related enums grouped.

Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that was just a mistake, there should be no relation.
Thanks for fixing


case SUPPORTS_DYNAMIC_FILTER_PUSHDOWN:
// Dynamic filters can be pushed down only if predicate push down is supported.
Expand Down