Fix delete, truncate behavior in BaseJdbcConnectorTest#14251
Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom Sep 22, 2022
Merged
Fix delete, truncate behavior in BaseJdbcConnectorTest#14251Praveen2112 merged 1 commit intotrinodb:masterfrom
Praveen2112 merged 1 commit intotrinodb:masterfrom
Conversation
They should be independent of whether connector supports dynamic filtering
Praveen2112
commented
Sep 22, 2022
| switch (connectorBehavior) { | ||
| case SUPPORTS_DELETE: | ||
| case SUPPORTS_TRUNCATE: | ||
| return true; |
Member
Author
There was a problem hiding this comment.
Was it inter-related for any reason ?
Member
There was a problem hiding this comment.
Logical mistake in https://github.com/trinodb/trino/pull/13334/files#diff-6d69520925faa8f876d78d002c7ad94202dfc4a81a9758a5bc3f2ba93b40e023R128
One more reason in favour of @findepi's idea to keep only related enums grouped.
Member
There was a problem hiding this comment.
I think that was just a mistake, there should be no relation.
Thanks for fixing
hashhar
approved these changes
Sep 22, 2022
raunaqmorarka
approved these changes
Sep 22, 2022
| switch (connectorBehavior) { | ||
| case SUPPORTS_DELETE: | ||
| case SUPPORTS_TRUNCATE: | ||
| return true; |
Member
There was a problem hiding this comment.
I think that was just a mistake, there should be no relation.
Thanks for fixing
findepi
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delete and truncate behavior should be independent of whether connector supports dynamic filtering
Non-technical explanation
NA
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: