Skip to content

Rename Presto references to Trino in product tests launcher#14195

Merged
kokosing merged 4 commits intotrinodb:masterfrom
nevillelyh:neville/ptl-trino
Sep 27, 2022
Merged

Rename Presto references to Trino in product tests launcher#14195
kokosing merged 4 commits intotrinodb:masterfrom
nevillelyh:neville/ptl-trino

Conversation

@nevillelyh
Copy link
Copy Markdown
Member

@nevillelyh nevillelyh commented Sep 19, 2022

Description

Rename code references of Presto to Trino per #14149 (comment)

  • Only code references, e.g. method & variable names, comments
  • String literals & config files are kept as is

Non-technical explanation

Release notes

(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2022
@nevillelyh nevillelyh force-pushed the neville/ptl-trino branch 2 times, most recently from e008b9f to 816e84d Compare September 19, 2022 20:58
@nevillelyh nevillelyh requested a review from kokosing September 20, 2022 12:45
@lukasz-walkiewicz
Copy link
Copy Markdown
Member

There are also container and file names that eventually should be renamed as well but it will be probably a lot more complex as every reference would have to be changed including those in SSL certs.

@nevillelyh
Copy link
Copy Markdown
Member Author

@lukasz-walkiewicz yeah I left those alone for this exact reason. Can save them for later.

@kokosing kokosing merged commit 258cf97 into trinodb:master Sep 27, 2022
@github-actions github-actions bot added this to the 398 milestone Sep 27, 2022
@nevillelyh nevillelyh deleted the neville/ptl-trino branch September 27, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants