Lower Kafka log level in product tests#14149
Merged
kokosing merged 1 commit intotrinodb:masterfrom Sep 19, 2022
Merged
Conversation
Member
There was a problem hiding this comment.
Slightly better approach is to use:
private final DockerFiles.ResourceProvider configDir;
and get referrence to all config files only once (typically in the constuctor) via:
configDir = dockerFiles.getDockerFilesHostDirectory("common/kafka");
Member
There was a problem hiding this comment.
nit: extract copying of the file to a method?
Member
There was a problem hiding this comment.
Another approach is:
builder.configureContainers(dockerContainer -> {
if (isPrestoContainer(dockerContainer.getLogicalName())) {
dockerContainer
.withCopyFileToContainer(
forHostPath(configDir.getPath("log.properties")),
CONTAINER_PRESTO_ETC + "/log.properties");
}
});
kokosing
reviewed
Sep 16, 2022
Member
kokosing
left a comment
kokosing
left a comment
There was a problem hiding this comment.
Have you checked Trino server logs? What is the diff between before and after?
Member
There was a problem hiding this comment.
Another approach is:
builder.configureContainers(dockerContainer -> {
if (isPrestoContainer(dockerContainer.getLogicalName())) {
dockerContainer
.withCopyFileToContainer(
forHostPath(configDir.getPath("log.properties")),
CONTAINER_PRESTO_ETC + "/log.properties");
}
});
nevillelyh
force-pushed
the
neville/kafka-log
branch
from
6530fd1 to
ae6a460
Compare
Member
Author
Yeah tried querying a Kafka table. I think
And the verbose logging before: |
lukasz-walkiewicz
approved these changes
Sep 19, 2022
hashhar
approved these changes
Sep 19, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
In addition to consumer config we'd also log from admin client + producer depending on what operation is being done.
We can target others if they turn out to be an issue but this tackles the bulk of the logs.
kokosing
approved these changes
Sep 19, 2022
|
|
||
| MountableFile logConfigFile = forHostPath(configDir.getPath("log.properties")); | ||
| builder.configureContainers(container -> { | ||
| if (isPrestoContainer(container.getLogicalName())) { |
Member
There was a problem hiding this comment.
would like to rename isPrestoContainer to isTrinoContainer as separate PR?
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lower Kafka log level in product tests
Non-technical explanation
Make Kafka product tests less noisy
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: