Fail query if source handles cannot be acquired#14117
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Sep 14, 2022
Merged
Fail query if source handles cannot be acquired#14117losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk merged 2 commits intotrinodb:masterfrom
Conversation
Member
Author
|
@arhimondr it works but maybe it should be done differently. I am open for suggestions :) |
arhimondr
approved these changes
Sep 13, 2022
Member
Author
|
CI: #14035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the exchange plugin reported an error in future for returning ExchangeSourceHandles
this error was ignored by the engine and the query would hang indefinitely.
Technically it is a bug but not observable with exchange implementations distributed with Trino right now (hence no RN)
Non-technical explanation
Release notes
(x) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: