Allow writing to Delta Lake tables using writer v3#14068
Allow writing to Delta Lake tables using writer v3#14068ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
|
Can someone kick off a run with secrets? I was not able to run the new test locally |
| assertQueryFailure(() -> onTrino().executeQuery("UPDATE " + tableName + " SET a = 3 WHERE b = 3")) | ||
| .hasMessageContaining("Writing to tables with CHECK constraints is not supported"); | ||
| assertQueryFailure(() -> onTrino().executeQuery("DELETE FROM " + tableName + " WHERE a = 3")) | ||
| .hasMessageContaining("Writing to tables with CHECK constraints is not supported"); |
There was a problem hiding this comment.
you are missing a test for MERGE here ;)
|
Thanks, added a merge test and one to make sure that changing column comments, adding table comments, and adding columns retains the check constraint metadata. |
|
Delta tests are failing, might be related. |
alexjo2144
force-pushed
the
delta/check-constraints
branch
from
5cca6f1 to
d612d89
Compare
|
Had to fix some error messages. Thanks |
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Outdated
Show resolved
Hide resolved
| assertQueryFailure(() -> onTrino().executeQuery("DELETE FROM delta.default." + tableName + " WHERE a = 3")) | ||
| .hasMessageContaining("Writing to tables with CHECK constraints is not supported"); |
There was a problem hiding this comment.
Why do we want to disable DELETE when a table has check constraints? Is there any situation deleting rows violate check constraints?
I'm fine with disallowing it because allowing only DELETE looks not useful. Just asking to understand the context.
There was a problem hiding this comment.
It should be safe to enable as long as the check constraints are only row by row. I think I'd opt to leave it disabled for now though and we can enable it when we come back and take a closer look at supporting check constraints.
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Outdated
Show resolved
Hide resolved
This version includes CHECK constraints, which are not yet supported.
alexjo2144
force-pushed
the
delta/check-constraints
branch
from
d612d89 to
6fdca7c
Compare
|
Renamed those two tests, thanks @ebyhr |
|
Merged, thanks! |
4 participants
Description
This version includes CHECK constraints, which are not yet supported. The minimum required support is just to fail writes to tables that have these constraints.
Non-technical explanation
Allow writes to Delta tables using writer version 3. This does not yet include support for CHECK constraints.
Release notes
( ) This is not user-visible and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: