Migrate various functions tests to QueryAssertions#14041
Merged
martint merged 12 commits intotrinodb:masterfrom Sep 9, 2022
Merged
Migrate various functions tests to QueryAssertions#14041martint merged 12 commits intotrinodb:masterfrom
martint merged 12 commits intotrinodb:masterfrom
Conversation
In preparation to add support for binding values. Adds a new evaluate() method to force evaluation, which is needed for usages in the context of assertThrownBy()
Also, deprecate various methods in FunctionAssertions and AbstractTestFunctions in favor of these.
martint
force-pushed
the
function-assertions
branch
2 times, most recently
from
9063a26 to
17dd1ef
Compare
Syntactic sugar for:
assertThat(...)
.hasType(type)
.isNull()
dain
approved these changes
Sep 8, 2022
core/trino-main/src/test/java/io/trino/operator/scalar/TestArrayFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/scalar/TestConditions.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
function-assertions
branch
from
17dd1ef to
4e64d0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractTestFunctions relies on internal implementation details of the analyzer, planner and optimizer, which makes it hard/impossible to proceed with splitting the AST from IR. This PR is the initial step towards migrating all the tests based on that class to use QueryAssertions and go through the front door of the engine.
Release notes
(x) This is not user-visible and no release notes are required.