Increase default domain-compaction-threshold for phoenix, clickhouse#14029
Merged
raunaqmorarka merged 3 commits intotrinodb:masterfrom Sep 9, 2022
Merged
Increase default domain-compaction-threshold for phoenix, clickhouse#14029raunaqmorarka merged 3 commits intotrinodb:masterfrom
raunaqmorarka merged 3 commits intotrinodb:masterfrom
Conversation
sopel39
approved these changes
Sep 7, 2022
plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixClient.java
Outdated
Show resolved
Hide resolved
mosabua
approved these changes
Sep 7, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Documentation looks good. The large range of default values is wild, but I assume thats a consequence of the different data sources.
This allows specifying the default for each connector separately
raunaqmorarka
force-pushed
the
inc-domain
branch
from
1143a66 to
95d15ee
Compare
Closed
Member
|
Thank you @raunaqmorarka ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase default domain-compaction-threshold for phoenix, clickhouse
Update docs for jdbc domain-compaction-threshold
Non-technical explanation
Allows pushdown of larger predicates into phoenix and clickhouse by default.
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: