Skip to content

Truncate month names in release note headers#14017

Merged
martint merged 1 commit intotrinodb:masterfrom
colebow:colebow/rn-date-edit
Sep 8, 2022
Merged

Truncate month names in release note headers#14017
martint merged 1 commit intotrinodb:masterfrom
colebow:colebow/rn-date-edit

Conversation

@colebow
Copy link
Copy Markdown
Member

@colebow colebow commented Sep 6, 2022

Description

I've just now realized that all of our months in headers for past release notes have been 3 characters, but since I've taken over writing them, I've been spelling out the whole month. This has been fine up until this month, but 'September' needs to be abbreviated to 'Sep' to avoid the sidebar wrapping onto a second line, and we should probably fix all the past notes for consistency's sake.

Non-technical explanation

Updating release notes.

Release notes

  • This is not user-visible and no release notes are required.
  • Release notes are required, please propose a release note for me.
  • Release notes are required, with the following suggested text:

...kinda feels like maybe that release note selection isn't the best... might add "This is a docs change and no release notes are required."

@cla-bot cla-bot bot added the cla-signed label Sep 6, 2022
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@findepi
Copy link
Copy Markdown
Member

findepi commented Sep 7, 2022

  • This is not user-visible and no release notes are required.
  • Release notes are required, please propose a release note for me.
  • Release notes are required, with the following suggested text:

Thanks for using checkboxes here.
Where can I see the negative consequences of the fact that PR description contains checkboxes?

@martint martint merged commit d33ab04 into trinodb:master Sep 8, 2022
@github-actions github-actions bot added this to the 396 milestone Sep 8, 2022
@colebow colebow deleted the colebow/rn-date-edit branch September 8, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants