Minor cleanups in JdbcConnectorTest#13959
Closed
Praveen2112 wants to merge 1 commit intotrinodb:masterfrom
Closed
Conversation
Praveen2112
added
the
no-release-notes
Praveen2112
changed the title
Praveen2112
force-pushed
the
praveen/temporary_relation
branch
4 times, most recently
from
cb3b8e5 to
7b6f41a
Compare
Praveen2112
changed the title
Member
|
@Praveen2112 MemSQL tests don't run when submitted from forks. (Mostly a reminder to myself to make sure MemSQL works before merging this). |
- Use TemporaryRelation instead of TestTable - Allow customization of schemaName specific to connector implementation
Praveen2112
force-pushed
the
praveen/temporary_relation
branch
from
7b6f41a to
2e66c62
Compare
Member
nit: the previous PR title was more informative. |
Member
Author
|
@hashhar Will raise the PR as a branch in the main repo for memsql related tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactoring
JDBC connector testing module.
Refactoring on testing module.
Related issues, pull requests, and links
#13260
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: