Introduce TemporaryRelation #13260
Merged
Praveen2112 merged 1 commit intotrinodb:masterfrom Jul 27, 2022
Merged
Conversation
Praveen2112
force-pushed
the
data_setup_cleanup
branch
from
7846906 to
c68dbb7
Compare
Member
|
It will be easier to see how useful this is (or whether interface has limitations) with a non-TestTable implementation as well. Kudu/Phoenix might be a good place to start since both require some additional properties during CREATE TABLE. Druid/Pinot/Kafka are the end-goal IMO but maybe too much work for this PR. |
Member
Author
|
I could raise a follow up PR for Druid. It could be too big for this PR |
findepi
approved these changes
Jul 21, 2022
testing/trino-testing/src/main/java/io/trino/testing/sql/TemporaryRelation.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
data_setup_cleanup
branch
from
c68dbb7 to
1ee0f76
Compare
hashhar
approved these changes
Jul 21, 2022
findepi
approved these changes
Jul 22, 2022
Praveen2112
force-pushed
the
data_setup_cleanup
branch
from
1ee0f76 to
8446ac5
Compare
Member
Author
Praveen2112
force-pushed
the
data_setup_cleanup
branch
from
8446ac5 to
2799ef0
Compare
DataSetup has a restriction that its implementation Data source should support SQL compatible CREATE and INSERT operation. TemporaryRelation remove this restriction, thereby allowing support for additional Data sources.
Praveen2112
force-pushed
the
data_setup_cleanup
branch
from
2799ef0 to
3229c8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataSetup has a restriction that its implementation Data source should support SQL compatible
CREATE and INSERT operation. TemporaryRelation remove this restriction, thereby allowing support
for additional Data sources.
Extracted from this comment - https://github.com/trinodb/trino/pull/8474/files#r674815466
Description
Refactoring
Refactoring in tests
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: