Push whole join condition into connectors#13943
Merged
findepi merged 3 commits intoSep 12, 2022
Merged
Conversation
assaf2
reviewed
Sep 1, 2022
assaf2
approved these changes
Sep 1, 2022
findepi
force-pushed
the
findepi/expressive-join-pushdown
branch
from
a858fb2 to
a845f2b
Compare
- The expression and its symbol types should be passed next to each other. - TypeAnalyzer is usually provided after PlannerContext (until it's made part of it)
findepi
force-pushed
the
findepi/expressive-join-pushdown
branch
from
a845f2b to
43d1ff5
Compare
Move translation of individual conjuncts from `PushPredicateIntoTableScan` into `ConnectorExpressionTranslator` to make it reusable. This also changes `ConnectorExpressionTranslation` into a record, which is very suitable for a composite method return type.
findepi
force-pushed
the
findepi/expressive-join-pushdown
branch
2 times, most recently
from
6282708 to
aac7399
Compare
assaf2
reviewed
Sep 6, 2022
Previously join pushdown was limited to simple comparison conditions between variables. That's because the `applyJoin` was added before we had real connector expressions. The commit exposes to connectors all join condition's conjuncts that are translatable to `ConnectorExpression`.
findepi
force-pushed
the
findepi/expressive-join-pushdown
branch
from
aac7399 to
1a984bb
Compare
Member
Author
assaf2
reviewed
Sep 7, 2022
hashhar
approved these changes
Sep 12, 2022
Member
|
Are docs / release notes needed for this? @findepi |
findepi
added
no-release-notes
Closed
Member
Author
|
Thanks @colebow , see #14047 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously join pushdown was limited to simple comparison conditions
between variables. That's because the
applyJoinwas added before wehad real connector expressions. The commit exposes to connectors all
join condition's conjuncts that are translatable to
ConnectorExpression.