Ensure test table contains multiple active files#13902
Ensure test table contains multiple active files#13902findepi merged 2 commits intotrinodb:masterfrom
Conversation
|
There's already one test with a partitioned table. Can we instead do a CTAS + INSERT to force multiple files? |
There was a problem hiding this comment.
I assume UNION (should be UNION ALL, really) was used to ensure multiple data files.
should we drop the second UNION branch now?
93dc211 to
ad623fe
Compare
|
Migrated the tests to use a |
ad623fe to
5ae0f8b
Compare
...lake/src/test/java/io/trino/plugin/deltalake/AbstractTestDeltaLakeCreateTableStatistics.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
i must admit i don't know what testMultiFileTable() is for.
Maybe we can remove it, or add a javadoc explaining its value
cc @alexjo2144
There was a problem hiding this comment.
I may have known at one point, but I'm also unsure if it has any value
There was a problem hiding this comment.
if we don't know why we have a test, we don't know what's a good change and what isn't for the test prep or assertions.
let's drop it.
There was a problem hiding this comment.
I dropped the useless test in a separate PR.
testMultiFileTableWithNaNValue has been reworked to ensure that the table tested contains multiple active files.
5ae0f8b to
0bcc4ba
Compare
0bcc4ba to
e24f30b
Compare
Description
Ensure that the table created in the test does indeed have multiple files by partitioning the table.
Assuming that an unpartitioned table will have multiple files after being created with a CTAS statement can lead to flakiness in the tests.
This change is related to test infrastructure and doesn't change the existing functionality of the production code.
Related issues, pull requests, and links
Fixes #13107