Skip to content

Support commenting on table and column in BigQuery#13882

Merged
ebyhr merged 2 commits intomasterfrom
ebi/bigquery-comments
Sep 9, 2022
Merged

Support commenting on table and column in BigQuery#13882
ebyhr merged 2 commits intomasterfrom
ebi/bigquery-comments

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Aug 27, 2022 •
edited
Loading

Description

Support commenting on table and column in BigQuery

Documentation

(x) Sufficient documentation is included in this PR.

Release notes

(x) Release notes entries required with the following suggested text:

# BigQuery
* Add support for [setting comments on tables](/sql/comment). ({issue}`13882`)
* Add support for [setting comments on columns](/sql/comment). ({issue}`13882`)

@cla-bot cla-bot bot added the cla-signed label Aug 27, 2022
@github-actions github-actions bot added the docs label Aug 27, 2022
@ebyhr ebyhr requested review from hashhar and wendigo August 29, 2022 00:11
hashhar
hashhar approved these changes Sep 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@ebyhr ebyhr force-pushed the ebi/bigquery-comments branch from b7871c5 to 4b7c78f Compare September 8, 2022 12:22
@ebyhr ebyhr requested review from hashhar and wendigo September 8, 2022 13:57
hashhar
hashhar approved these changes Sep 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A question - does BigQuery SDK provide API to set description? I wonder why we use SQL here (which is subject to queueing on the BigQuery side).

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Sep 9, 2022

There's no way to set only description as far as I confirmed. We need to provide whole new table definition to BigQuery#update. It may lead to concurrent issue when other job try to modify a table at the same time.

@ebyhr ebyhr merged commit d782bb6 into master Sep 9, 2022
@ebyhr ebyhr deleted the ebi/bigquery-comments branch September 9, 2022 00:10
@ebyhr ebyhr mentioned this pull request Sep 9, 2022
Closed
@github-actions github-actions bot added this to the 396 milestone Sep 9, 2022
@colebow colebow mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hashhar hashhar hashhar approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees

No one assigned

Labels

cla-signed docs

Milestone

396

Development

Successfully merging this pull request may close these issues.

3 participants

@ebyhr @wendigo @hashhar