Improve type mapping docs for Elasticsearch connector#13876
Improve type mapping docs for Elasticsearch connector#13876martint merged 1 commit intotrinodb:masterfrom
Conversation
351f5df to
70c0dd4
Compare
There was a problem hiding this comment.
What does "modifies some types" mean in this context?
There was a problem hiding this comment.
In the context of a read-only connector like this, just that the Elasticsearch data types are not necessarily the types used in Trino when reading, so some modification occurs in the engine/connector.
That ref link goes here, to this general type mapping explanation that just got merged earlier today - https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/language/types.rst#trino-type-support-and-mapping
There was a problem hiding this comment.
I think it's misleading. The types are not "modified", in the engine or elsewhere. The types from ES get mapped into Trino types, that's all.
There was a problem hiding this comment.
I think that works for me. Just make sure whatever wording gets merged here then gets applies to all other connectors.
949ca8f to
c750c4f
Compare
c750c4f to
2780114
Compare
Description
Improve type mapping documentation for Elasticsearch connector.
Improvement to Elasticsearch connector documentation
Added data type mapping for write direction (Trino --> Elasticsearch); reformatted table for better wrapping; added boilerplate headings and verbiage for consistency.
Question for SMEs: I wasn't sure about the new write table to avoid 1:m mapping in the write direction. I assume that
textmight be preferred overkeywordbased on https://stackoverflow.com/questions/52845088/difference-between-keyword-and-text-in-elasticsearch. Please advise.Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: