Add predicate to ParquetReader constructor in Iceberg#13804
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Sep 7, 2022
Merged
Add predicate to ParquetReader constructor in Iceberg#13804raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
charlesjmorgan
force-pushed
the
cm/pq-iceberg-params
branch
from
2e7da29 to
523d01f
Compare
Member
|
It seems better to get rid of this constructor entirely: #13584 |
Member
Author
charlesjmorgan
force-pushed
the
cm/pq-iceberg-params
branch
from
523d01f to
847b216
Compare
Contributor
@charlesjmorgan if there is something else requiring this constructor that is annoying to migrate before the constructor can be removed, i think we can do that later. It should be easy enough to do separately without affecting anything here. |
charlesjmorgan
force-pushed
the
cm/pq-iceberg-params
branch
from
847b216 to
bb6cae3
Compare
skrzypo987
approved these changes
Aug 30, 2022
sopel39
reviewed
Aug 30, 2022
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ParquetReader.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Aug 31, 2022
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ParquetReader.java
Outdated
Show resolved
Hide resolved
Add requireNonNull on parquetPredicate and columnIndexStore in ParquetReader, pass Optional.empty() from Iceberg for parquetPredicate param
charlesjmorgan
force-pushed
the
cm/pq-iceberg-params
branch
from
bb6cae3 to
5bf6c1c
Compare
raunaqmorarka
approved these changes
Sep 6, 2022
Member
|
Test failure is from #13889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
parquetPredicateparameter Optional inParquetReaderconstructor and passOptional.empty()from Iceberg toParquetReaderconstructor. AddrequireNonNulltoparquetPredicateandcolumnIndexStoreinParquetReaderconstructor since they can no longer be null.Related issues, pull requests, and links
Documentation
(X) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(X) No release notes entries required.
( ) Release notes entries required with the following suggested text: