Restore TIMELINE logging and add query state#13698
Merged
electrum merged 1 commit intotrinodb:masterfrom Aug 17, 2022
Merged
Conversation
dain
approved these changes
Aug 17, 2022
Member
|
@electrum what was the reasoning for the revert? |
Member
|
@djsstarburst do you happen to know the reasoning for the revert? |
Member
@findepi - - I think @dain found the TIMELINE logging very useful in debugging a problem for a Galaxy customer. In fact, @dain would like to add some additional information to those log lines. And sadly, even with the now-reverted PR, the Iceberg CI build log files at 11 MB are too large to be displayed in the web interface, since the threshold is reported to be 10MB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
improvement
Related
Documentation
(x) No documentation is needed.
Release notes
(x) Release notes entries required with the following suggested text:
NOTE: this replaces the
Reduce log level of query timeline messages to debugchange.