Skip to content

Log TIMELINE summaries at the debug level#13668

Merged
electrum merged 1 commit intotrinodb:masterfrom
djsagain:david.stryker/timeline-log-debug
Aug 15, 2022
Merged

Log TIMELINE summaries at the debug level#13668
electrum merged 1 commit intotrinodb:masterfrom
djsagain:david.stryker/timeline-log-debug

Conversation

@djsagain
Copy link
Member

@djsagain djsagain commented Aug 14, 2022

NOTE: this was reverted by #13698

Description

At the info level, they represent more than half the log
lines in many tests.

Is this change a fix, improvement, new feature, refactoring, or other?
Minor logging change.
Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
Core engine
How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.

At the info level, they represent more than half the log
lines in many tests.
@cla-bot cla-bot bot added the cla-signed label Aug 14, 2022
@djsagain djsagain requested review from dain, electrum and findepi August 14, 2022 00:55
@hashhar
Copy link
Member

hashhar commented Aug 14, 2022

cc: @nineinchnick since he did some work in past to reduce logs.

@electrum electrum merged commit 421bea5 into trinodb:master Aug 15, 2022
@github-actions github-actions bot added this to the 393 milestone Aug 15, 2022
@hashhar
Copy link
Member

hashhar commented Aug 16, 2022

This could've been limited to be a test-only change instead of applying generally to the entire engine.

@findepi
Copy link
Member

findepi commented Aug 22, 2022

followed up (reverted) in #13698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants