Remove redundant singleThreaded-ness annotation from TestConnectorEventListener#13646
Merged
findepi merged 2 commits intotrinodb:masterfrom Aug 22, 2022
Conversation
findepi
added
test
no-release-notes
findepi
requested review from
dain,
hashhar,
kokosing,
lukasz-walkiewicz and
s2lomon
…ntListener The class does not seem to have any mutable state besides `EventsCollector`, which is `@ThreadSafe` and differentiates between queries by the query id since b370bf8.
findepi
force-pushed
the
findepi/remove-redundant-singlethreaded-ness-annotation-from-testconnectoreventlistener-7df0a5
branch
from
27298e9 to
861c81b
Compare
kokosing
approved these changes
Aug 12, 2022
hashhar
approved these changes
Aug 13, 2022
lukasz-walkiewicz
approved these changes
Aug 17, 2022
Member
Author
|
CI #13638 (fixed in the meantime) |
findepi
deleted the
findepi/remove-redundant-singlethreaded-ness-annotation-from-testconnectoreventlistener-7df0a5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class does not seem to have any mutable state besides
EventsCollector, which is@ThreadSafeand differentiates betweenqueries by the query id since b370bf8 (#13274).
Not related to #3364 because the class currently has single test method anyway.