Merged
Conversation
dain
force-pushed
the
fix-events-collector
branch
from
d0c6cf3 to
e66d39c
Compare
losipiuk
reviewed
Jul 21, 2022
core/trino-main/src/main/java/io/trino/testing/LocalQueryRunner.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jul 21, 2022
testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jul 21, 2022
testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Jul 21, 2022
testing/trino-tests/src/test/java/io/trino/execution/EventsCollector.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
fix-events-collector
branch
2 times, most recently
from
465ff89 to
63322ff
Compare
Member
Author
|
I simplified this PR by not adding the new method to query runner since the logic is only needed with a |
electrum
approved these changes
Jul 21, 2022
losipiuk
approved these changes
Jul 22, 2022
Uses of ResultWithQueryId out side of some AbstractTestingTrinoClient always use MaterializedResult, and this change simplifies those usages. The new class will be used in QueryRunner to get results and query id for testing events.
When testing it can be important to know the query id when a query fails.
The old design was more complex because all events were collected together and this caused complex threading issues.
dain
force-pushed
the
fix-events-collector
branch
from
2a80d3d to
92533f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a new attempt at fixing #5922. The new fix rewrites EventsCollector to collect events on a per query basis, which eliminates the concurrency issues of separating events from different queries. This requires exposing the
QueryIdto results fromQueryRunnerexecutions including in exceptions.Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: