Added BaseConnectorSmokeTest as a base class for Pinot SmokeTest#13619
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Sep 8, 2022
Merged
Added BaseConnectorSmokeTest as a base class for Pinot SmokeTest#13619ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
from
d90e183 to
834a8cc
Compare
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
from
834a8cc to
abce44f
Compare
ebyhr
reviewed
Aug 14, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please squash commits and fix the commit title.
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/TestingConnectorBehavior.java
Outdated
Show resolved
Hide resolved
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
3 times, most recently
from
e4daf19 to
dc78376
Compare
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
3 times, most recently
from
eedac40 to
cda4857
Compare
ebyhr
reviewed
Aug 23, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
The commit title is too long. Could you simplify them?
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
plugin/trino-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...no-pinot/src/test/java/io/trino/plugin/pinot/AbstractPinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
1082
to
1098
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
4 times, most recently
from
442686f to
48c3de8
Compare
ebyhr
added
the
no-release-notes
ebyhr
reviewed
Sep 5, 2022
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
5 times, most recently
from
19d1ebf to
3c4084d
Compare
Member
|
Could you please confirm CI failures? |
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
2 times, most recently
from
e0c08b0 to
7229c83
Compare
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
2 times, most recently
from
3e2e9dd to
8c8d79f
Compare
ebyhr
approved these changes
Sep 7, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please change the commit title as
- Extract method to prepare Pinot testing tables
- Extend BaseConnectorSmokeTest in Pinot tests
The point is avoiding past tense and clarifying the change of "refactor". Please note that the 2nd commit isn't refactoring actually.
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
.../trino-pinot/src/test/java/io/trino/plugin/pinot/BasePinotIntegrationConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
from
8c8d79f to
c38f940
Compare
Made the AbstractPinotIntegrationSmokeTest to extended the same to BaseConnectorSmokeTest Renamed AbstractPinotIntegrationSmokeTest to BasePinotIntegrationConnectorSmokeTest
ntantri
force-pushed
the
change-pinot-testing-base-class
branch
from
c38f940 to
6bd1802
Compare
ebyhr
reviewed
Sep 8, 2022
| @Override | ||
| public void testShowCreateTable() | ||
| { | ||
| assertQueryFails("SHOW CREATE TABLE region", "No PropertyMetadata for property: pinotColumnName"); |
Member
|
Merged. Extending |
Member
|
This is great! |
Member
Author
|
Thanks for patiently reviewing all the work @ebyhr! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues pull requests and links
Documentation
✅ No documentation is needed.
Release notes
✅ No release notes entries required.