Skip to content

Fix more deprecated Parquet API usage#13554

Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom
nevillelyh:neville/parquet-deprecation
Aug 19, 2022
Merged

Fix more deprecated Parquet API usage#13554
raunaqmorarka merged 1 commit intotrinodb:masterfrom
nevillelyh:neville/parquet-deprecation

Conversation

@nevillelyh
Copy link
Copy Markdown
Member

@nevillelyh nevillelyh commented Aug 9, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix more deprecated Parquet API usage:

  • Binary
  • ColumnChunkMetadata
  • ColumnDescriptor
  • Statistics

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

lib/trino-parquet and plugin/trino-hive connector

How would you describe this change to a non-technical end user or system administrator?

Fix deprecated API usage

Related issues, pull requests, and links

Part of #1802

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 9, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@raunaqmorarka
Copy link
Copy Markdown
Member

Please drop the references to GH issues in the commit messages

@nevillelyh nevillelyh force-pushed the neville/parquet-deprecation branch from 63b85df to 562f5e3 Compare August 9, 2022 13:23
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 9, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nevillelyh nevillelyh changed the title Fix more deprecated Parquet API usage #1802 Fix more deprecated Parquet API usage Aug 9, 2022
@nevillelyh nevillelyh force-pushed the neville/parquet-deprecation branch from 562f5e3 to d3cf981 Compare August 18, 2022 20:46
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 18, 2022

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@martint
Copy link
Copy Markdown
Member

martint commented Aug 18, 2022

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 18, 2022
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Aug 18, 2022

The cla-bot has been summoned, and re-checked this pull request!

Update usage of the following APIs in trino-parquet
- Binary
- ColumnChunkMetaData
- ColumnDescriptor
- Statistics
@nevillelyh nevillelyh force-pushed the neville/parquet-deprecation branch from d3cf981 to 5a5e2d3 Compare August 19, 2022 13:14
@raunaqmorarka raunaqmorarka merged commit 0998cf8 into trinodb:master Aug 19, 2022
@github-actions github-actions bot added this to the 394 milestone Aug 19, 2022
@nevillelyh nevillelyh deleted the neville/parquet-deprecation branch August 22, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants