Fix failure when matching empty dictionary#10873
Merged
martint merged 1 commit intotrinodb:masterfrom Aug 19, 2022
Merged
Conversation
8aa5496 to
615f675
Compare
martint
commented
Feb 1, 2022
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
skrzypo987
approved these changes
Feb 2, 2022
raunaqmorarka
approved these changes
Feb 2, 2022
Member
|
The CI didn't run here. |
findepi
approved these changes
Mar 25, 2022
Member
|
Any plan to merge this soon? |
|
Hi, with that fix applied Trino returns us 0 rows, when perform |
xtto
reviewed
May 13, 2022
lib/trino-parquet/src/main/java/io/trino/parquet/predicate/TupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
b27528c to
4e5df34
Compare
Member
Author
|
@kantonczak, can you try with the latest updates to this PR? |
|
+1 on this issue and fix, this issue is preventing me from migrating from Presto to Trino. |
Contributor
|
@martint the issue can be reproduced by writing a parquet file with pyarrow: import pyarrow
from pyarrow import parquet
with open("foo.parquet", "wb") as fp:
parquet.write_table(pyarrow.Table.from_arrays([pyarrow.array([None,None,None,None])], names=["x"]), fp)I will send the parquet file in trino slack. Repro query: CREATE TABLE test_null_parquet (x VARCHAR) WITH (format='PARQUET', external_location='s3a://.../foo.parquet');
SELECT * FROM test_null_parquet WHERE x IS NULL;
Query 20220817_185451_00007_yq9np, FAILED, 1 node
Splits: 5 total, 0 done (0.00%)
1.76 [0 rows, 0B] [0 rows/s, 0B/s]
Query 20220817_185451_00007_yq9np failed: Error opening Hive split s3a://.../nick/foo/myparquet.parquet (offset=0, length=408): cannot use empty rangeList |
77a4294 to
d4f36e2
Compare
c10a162 to
6a7594c
Compare
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/TestTupleDomainParquetPredicate.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/parquet/TestOnlyNulls.java
Outdated
Show resolved
Hide resolved
6a7594c to
9122fe8
Compare
raunaqmorarka
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9424
Release note: