Revert "Improve Iceberg deletes when an entire file can be removed"#13485
Merged
findepi merged 2 commits intotrinodb:masterfrom Aug 11, 2022
Merged
Conversation
Member
Author
|
@findepi added a regression test |
Member
|
@alexjo2144 please see build failures |
alexjo2144
force-pushed
the
iceberg/revert-whole-file-deletion
branch
3 times, most recently
from
6dc9cc9 to
b9bf619
Compare
This reverts commit 9ddaa60. Including both a RowDelta and a DeleteFiles commit in the same Iceberg transaction results in the table history being cleared. Instead only write RowDeltas, even in the case where a file can be fully removed.
alexjo2144
force-pushed
the
iceberg/revert-whole-file-deletion
branch
from
b9bf619 to
cc786ae
Compare
Member
Author
|
The changes introduced by Merge made this more complex than a simple revert, but should be passing now. |
findepi
approved these changes
Aug 10, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
iceberg/revert-whole-file-deletion
branch
from
cc786ae to
7ad6caf
Compare
findepi
approved these changes
Aug 10, 2022
Member
FYI, added this in the description. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 9ddaa60.
Including both a RowDelta and a DeleteFiles commit in the same Iceberg transaction
results in the table history being cleared. Instead only write RowDeltas,
even in the case where a file can be fully removed.
Fix
Iceberg connector
Ensures Trino does not clear Iceberg table history when it's not expected.
Related issues, pull requests, and links
Quick fix for: #12843
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:
Fixes #12843