Disable support for snapshot id within the Iceberg table name

[findinpath]

Description

Disable the possibility of specifying the snapshot id
within the Iceberg table name.

With the introduction of the syntax

table1 FOR VERSION AS OF 123

there is no more need of supporting the
deprecated syntax:

table1@123

Is this change a fix, improvement, new feature, refactoring, or other?

Other.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Iceberg connector

How would you describe this change to a non-technical end user or system administrator?

Use table1 FOR VERSION AS OF 123 instead of table1@123 for retrieving the snapshot 123 of table.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( x) Release notes entries required with the following suggested text:

# Iceberg
* Disable support for specifying the snapshot id within the Iceberg table name

[findinpath]

@findepi @phd3 @electrum PTAL on this PR

[alexjo2144]

This looks like a regression to me, does the AS OF syntax work as a replacement for select * from abc$manifests@456?

[findinpath]

I have a PR for supporting time travel queries on system tables but it is unfortunately not ready yet.

#12737

[findinpath]

Probably it is best to introduce the ability to perform time travel queries on system tables before continuing with this PR.

[findinpath]

As shown in the PRs:

• Support snapshot queries on Iceberg system tables - IcebergSystemTableHandle is a ConnectorTableHandle with custom instanceof handling in IcebergMetadata #13497
• Support snapshot queries on Iceberg system tables - custom IcebergSystemTableHandle extends SystemTableHandle #13854

time travel on system tables incurs added complexity to the Iceberg connector code.

Without concrete demand from the community for time travel functionality on system tables, we leave the above mentioned PRs on hold and go further with disabling support for snapshot id within the Iceberg table name.

[findepi]

This looks like a regression to me

correct

does the AS OF syntax work as a replacement for select * from abc$manifests@456?

no

The reason we're not pursing the above linked PRs is because we believe there is little community interest in these.
If there isn't general demand on time travel on system tables, we should be OK with carrying out removal of this (already deprecated) functionality.

[findinpath]

In the context of deprecating the tableName@snapshotId syntax, maybe it is worth also rewriting io.trino.plugin.iceberg.IcebergTableHandle#toString to use tableName FOR VERSION AS OF snapshotId syntax.

[findepi]

@findinpath there is a test failure. is it related?

[findepi]

In the context of deprecating the tableName@snapshotId syntax, maybe it is worth also rewriting io.trino.plugin.iceberg.IcebergTableHandle#toString to use tableName FOR VERSION AS OF snapshotId syntax.

This is used in EXPLAIN.
Let's keep it terse (no change), since this will always be there, for every SELECT, not only for time travel queries.

[findinpath]

@findepi failure of the tests was related to my changes. I fixed the failing test failure and rebased on master due to conflicts which appeared in the meantime.

[findepi]

Suggested change

	long snapshotId = endVersion.map(connectorTableVersion -> getSnapshotIdFromVersion(table, connectorTableVersion)).get();
	long snapshotId = getSnapshotIdFromVersion(table, endVersion.get());

[findepi]

getCurrentSnapshotId

[findepi]

No release notes since the functionality was already deprecated.