Merged
Conversation
This was referenced Aug 20, 2019
Closed
kokosing
approved these changes
Aug 20, 2019
Member
There was a problem hiding this comment.
can you add a test that for two different ints that represents NaN in float they are producing same hash? That would be much better than a comment in the code.
Member
Author
There was a problem hiding this comment.
I'd need a new connector where I can force a particular bits representation of a NaN value...
Member
Author
There was a problem hiding this comment.
Thanks for catching me. I added a unit test and it told me there's another method to update.
This matches https://github.com/apache/hive/blob/ba83fd7bff/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L554 more closely. We already do *not* assume canonical on-stack representation for floats in `io.prestosql.spi.type.RealType#hash`.
Before the change, selecting `"$bucket"` would fail at run-time with ``` Query 20190820_065833_00012_nk9ff failed: No value present java.util.NoSuchElementException: No value present at java.util.OptionalInt.getAsInt(OptionalInt.java:118) at io.prestosql.plugin.hive.HiveUtil.getPrefilledColumnValue(HiveUtil.java:920) at io.prestosql.plugin.hive.HivePageSourceProvider$ColumnMapping.buildColumnMappings(HivePageSourceProvider.java:332) at io.prestosql.plugin.hive.HivePageSourceProvider.createHivePageSource(HivePageSourceProvider.java:143) at io.prestosql.plugin.hive.HivePageSourceProvider.createPageSource(HivePageSourceProvider.java:98) ```
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.