Skip to content

Add 318 release notes#1316

Merged
martint merged 1 commit intotrinodb:masterfrom
martint:relnotes
Aug 26, 2019
Merged

Add 318 release notes#1316
martint merged 1 commit intotrinodb:masterfrom
martint:relnotes

Conversation

@martint
Copy link
Copy Markdown
Member

@martint martint commented Aug 19, 2019

Many entries need editing. The PostgreSQL items need to be replicated for MySQL, etc.

Closes #1238

@cla-bot cla-bot bot added the cla-signed label Aug 19, 2019
martint
martint commented Aug 19, 2019
View reviewed changes
presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member Author

@martint martint Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ones and how did they change?

Copy link
Copy Markdown
Member Author

@martint martint Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sopel39?

Copy link
Copy Markdown
Member

@electrum electrum Aug 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to include the old and new property names.

findepi
findepi reviewed Aug 19, 2019
View reviewed changes
@sopel39
Copy link
Copy Markdown
Member

sopel39 commented Aug 19, 2019 

JDBC
----

* List schemas from current catalog only in JDBC connectors. (:issue:`1309`)

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 19, 2019

@martint should this be mentioned in RNs 24a40be#diff-e0284816dc894bb27744c956e222c2ae?

@sopel39
Copy link
Copy Markdown
Member

sopel39 commented Aug 19, 2019 

General
-------

* Improve performance of information schema tables. (:issue:`1306`)

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 20, 2019 •
edited
Loading 

PostgreSQL, MySQL, SQL Server, Redshift, but not Phoenix
---
* Add possibility to force mapping of certain types to ``varchar``. This can be enabled by setting
  ``jdbc-types-mapped-to-varchar`` to comma-separated list of type names. (:issue:`186`)

#186

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 21, 2019 

Hive
---
* Fix bucketing of ``NaN`` values of ``real`` type. Previously ``NaN`` values could be assigned a wrong bucket. (:issue:`1336`)
* Return proper error when selecting ``"$bucket"`` column from a table using Hive bucketing v2. (:issue:`1336`)

#1336

@findepi
Copy link
Copy Markdown
Member

findepi commented Aug 21, 2019 

Hive
---
* Fix reading collection delimiter set by Hive version earlier than 3.0. (:issue:`1321`)

#1321

electrum
electrum reviewed Aug 21, 2019
View reviewed changes
presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Change the semantics of the ``analysis_time_ms`` column in the ``system.runtime.queries``
table. Previously, it was the time spent on query planning. Now, it is the time spent on
semantic analysis of the query. (:issue:`1084`)

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Add ``planning_time_ms `` column to the ``system.runtime.queries`` table that shows
the time spent on query planning. This is the same value that used to be in the
``analysis_time_ms`` column. (:issue:`1084`)

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rewritten

Copy link
Copy Markdown
Member Author

@martint martint Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokosing, I'm not sure I understand what this is about. Where are the details displayed?

Copy link
Copy Markdown
Member

@findepi findepi Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web UI i think

Copy link
Copy Markdown
Member

@kokosing kokosing Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. It is about webui.

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List the user visible effect of this, if any, otherwise remove it.

Copy link
Copy Markdown
Member Author

@martint martint Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kokosing ?

findepi
findepi reviewed Aug 22, 2019
View reviewed changes
@martint martint force-pushed the relnotes branch 3 times, most recently from efda15e to 5ddef85 Compare August 24, 2019 15:55
findepi
findepi reviewed Aug 24, 2019
View reviewed changes
findepi
findepi reviewed Aug 24, 2019
View reviewed changes
findepi
findepi approved these changes Aug 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@martint
Copy link
Copy Markdown
Member Author

martint commented Aug 25, 2019

Updated. @electrum, any additional comments before I merge it?

electrum
electrum reviewed Aug 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, otherwise looks good

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to include the old and new property names.

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the above.

@martint
Copy link
Copy Markdown
Member Author

martint commented Aug 25, 2019

This comment seems not to have been addressed.

Which comment, @findepi's? I added the line he suggested below it.

@martint martint force-pushed the relnotes branch 2 times, most recently from 29c5d9b to 3b463fb Compare August 26, 2019 15:23
electrum
electrum approved these changes Aug 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rearrange the order of general so that all the adds are at the end?

presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Add session properties that allow overriding the query per-node memory limits

electrum
electrum reviewed Aug 26, 2019
View reviewed changes
presto-docs/src/main/sphinx/release/release-318.rst Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Add session properties that allow overriding the query per-node memory limits

@martint martint closed this Aug 26, 2019
@martint martint deleted the relnotes branch August 26, 2019 19:24
@martint martint merged commit 5d73cb6 into trinodb:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@electrum electrum electrum approved these changes

@dain dain dain left review comments

@kokosing kokosing kokosing left review comments

@findepi findepi findepi approved these changes

Assignees

No one assigned

Labels

cla-signed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release notes for 318

6 participants

@martint @sopel39 @findepi @electrum @dain @kokosing