Only remove Iceberg delete files when safe to do so#13343
Only remove Iceberg delete files when safe to do so#13343ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
I think you wanted if the whole table ?
|
@alexjo2144 so the changes made in #13012 in |
So I noticed one major problem with the original approach we had, which was that we assumed Overall, in hindsight I think this logic is more error prone than it's worth |
The initial implementation removed delete files from a partition even if the whole table was not scanned. This was fine, but assumes the enforced predicate describes entire partitions. This assumption will not be true after trinodb#13012
alexjo2144
force-pushed
the
iceberg/optimize-deletes
branch
from
3b361bd to
cf73dc9
Compare
|
@homar Could you please confirm the above comment by @alexjo2144? |
yes I think we should remove that logic :/ |
|
👍 |
|
Confirmed that Iceberg tests passed in #13400 |
|
Merged, thanks! |
4 participants
The initial implementation removed delete files from a partition
even if the whole table was not scanned. This was fine, but assumes
the enforced predicate describes entire partitions. This
assumption will not be true after #13012
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: