Skip to content

Comments

Set default shell for CI run commands#13291

Merged
findepi merged 1 commit intotrinodb:masterfrom
nineinchnick:ci-set-shell-defaults
Jul 25, 2022
Merged

Set default shell for CI run commands#13291
findepi merged 1 commit intotrinodb:masterfrom
nineinchnick:ci-set-shell-defaults

Conversation

@nineinchnick
Copy link
Member

Description

Use safer shell defaults to detect silent failures in CI steps executing shell commands.

Is this change a fix, improvement, new feature, refactoring, or other?
improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
ci

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@nineinchnick nineinchnick force-pushed the ci-set-shell-defaults branch from edef84d to 53fc730 Compare July 22, 2022 17:33
@nineinchnick nineinchnick added the no-release-notes This pull request does not require release notes entry label Jul 24, 2022
@findepi findepi merged commit 079fe43 into trinodb:master Jul 25, 2022
@nineinchnick nineinchnick deleted the ci-set-shell-defaults branch July 25, 2022 10:53
@github-actions github-actions bot added this to the 392 milestone Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants