Skip to content

Test CI shell configuration#13256

Closed
findepi wants to merge 4 commits intotrinodb:masterfrom
findepi:findepi/test-ci-shell
Closed

Test CI shell configuration#13256
findepi wants to merge 4 commits intotrinodb:masterfrom
findepi:findepi/test-ci-shell

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Jul 20, 2022

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 20, 2022
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jul 20, 2022

per https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference it seems the run workflow steps are run with bad (bash's default) configuration, i.e. lacking set -euo pipefail

since we use multi-command run steps like

run: |
          export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
          $MAVEN validate ${MAVEN_FAST_INSTALL} -pl '!:trino-docs,!:trino-server-rpm'
          # GIB doesn't run on master, so make sure the file always exist
          touch gib-impacted.log
          testing/trino-plugin-reader/target/trino-plugin-reader-*-executable.jar -i gib-impacted.log -p core/trino-server/target/trino-server-*-hardlinks/plugin > impacted-features.log
          echo "Impacted plugin features:"
          cat impacted-features.log

this would lead to masking errors.

currently, the PR only verifies documentation vs life

cc @nineinchnick @hashhar

@findepi findepi closed this Jul 21, 2022
@findepi findepi deleted the findepi/test-ci-shell branch July 21, 2022 14:26
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Jul 21, 2022

@nineinchnick

the test returned

+ printf '%s\n' ehxB
+ false
ehxB
Error: Process completed with exit code 1.

-- the set -e is enabled, which is good and most important
but set -u is not enabled, which is not good.
i would also want set -o pipefail to be enabled too

what do you think?

@nineinchnick
Copy link
Copy Markdown
Member

@nineinchnick

the test returned

+ printf '%s\n' ehxB
+ false
ehxB
Error: Process completed with exit code 1.

-- the set -e is enabled, which is good and most important but set -u is not enabled, which is not good. i would also want set -o pipefail to be enabled too

what do you think?

Let's try adding these: #13291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants