Document running Trino in a container#13193
Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom Jul 27, 2022
Merged
Conversation
nineinchnick
force-pushed
the
docs-containers
branch
from
580f66d to
4cdf9c3
Compare
nineinchnick
added
no-release-notes
Member
|
I am happy to have the client tools in a separate client folder .. make sense imho. In the past we decided not to do that because it breaks incoming links. Personally I think that is not a problem and the navigation makes the files easy to find anyway. |
nineinchnick
force-pushed
the
docs-containers
branch
from
4cdf9c3 to
d772d5c
Compare
nineinchnick
force-pushed
the
docs-containers
branch
from
d772d5c to
d5ef166
Compare
Member
Author
|
@mosabua I can try setting up redirects for moved pages using this https://documatt.gitlab.io/sphinx-reredirects/usage.html |
Member
Personally I don't think that is necessary. |
mosabua
requested changes
Jul 23, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Minor adjustments and then good to go.
nineinchnick
force-pushed
the
docs-containers
branch
from
d5ef166 to
e0cf453
Compare
nineinchnick
force-pushed
the
docs-containers
branch
from
e0cf453 to
000c58f
Compare
Member
Author
raunaqmorarka
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: