Skip to content

refactor(docs): Adding Note for Docker Configuration of Connectors#12497

Closed
kemalty wants to merge 1 commit intotrinodb:masterfrom
kemalty:docs/configuring-docker-compose
Closed

refactor(docs): Adding Note for Docker Configuration of Connectors#12497
kemalty wants to merge 1 commit intotrinodb:masterfrom
kemalty:docs/configuring-docker-compose

Conversation

@kemalty
Copy link
Member

@kemalty kemalty commented May 20, 2022

Description

For issue #12494 .

Adding "(in /etc/trino/catalog for Docker)" clause in connector pages
to highlight the configuration difference between tarball and Docker.

Is this change a fix, improvement, new feature, refactoring, or other?

Refactoring of Connector Docs

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

No

How would you describe this change to a non-technical end user or system administrator?

Adding an extra small note in existing notes to prevent confusions for configuration in different environments.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Adding (in ``/etc/trino/catalog`` for Docker) clause in connector pages
to highlight the configuration difference between tarball and Docker.
@cla-bot cla-bot bot added the cla-signed label May 20, 2022
@kemalty kemalty added the docs label May 20, 2022
@kemalty kemalty marked this pull request as ready for review May 20, 2022 15:37
@mosabua
Copy link
Member

mosabua commented May 20, 2022

See discussion in the raised issue. We should NOT do this as it would make the connector inconsistent with all other documentation.

@nineinchnick
Copy link
Member

Does #13193 make this obsolete?

@kemalty
Copy link
Member Author

kemalty commented Aug 22, 2022

Does #13193 make this obsolete?

I quickly checked the PR. It looks really good! I wish we had that document before. I think your PR makes this one obsolete indeed. Thanks for the new docs. It will make life easier for a lot of people :)

@kemalty kemalty closed this Aug 22, 2022
@kemalty kemalty deleted the docs/configuring-docker-compose branch August 22, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants