Prevent COMMENT ON TABLE statement for view and materialized view#13161
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Jul 13, 2022
Merged
Prevent COMMENT ON TABLE statement for view and materialized view#13161ebyhr merged 2 commits intotrinodb:masterfrom
COMMENT ON TABLE statement for view and materialized view#13161ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
Praveen2112
reviewed
Jul 13, 2022
Member
There was a problem hiding this comment.
Should we say the operation is not supported on MVs ?
Contributor
There was a problem hiding this comment.
I'm not very convinced that saying that the operation is not supported on MV is really necessary.
Additionally, implement setTableComment in BaseDataDefinitionTaskTest.
ebyhr
force-pushed
the
ebi/comment-table-on-view-mview
branch
from
f5a7317 to
c6da479
Compare
findinpath
approved these changes
Jul 13, 2022
Praveen2112
approved these changes
Jul 13, 2022
Member
Author
|
CI hit #13165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent
COMMENT ON TABLEstatement for view and materialized view.The similar logic exists in
RenameTableTask&DropTableTask.Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.