Support COMMENT ON VIEW statement in Hive & Iceberg connector#13147
Merged
Support COMMENT ON VIEW statement in Hive & Iceberg connector#13147
COMMENT ON VIEW statement in Hive & Iceberg connector#13147Conversation
ebyhr
force-pushed
the
ebi/hive-comment-view
branch
from
dc6bc3e to
d9f493c
Compare
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestComments.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestComments.java
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestComments.java
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Show resolved
Hide resolved
...test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java
Show resolved
Hide resolved
...test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.java
Show resolved
Hide resolved
Praveen2112
reviewed
Jul 13, 2022
ebyhr
force-pushed
the
ebi/hive-comment-view
branch
from
d9f493c to
fa8e7e5
Compare
Member
Author
|
@raunaqmorarka @Praveen2112 Addressed comments. |
raunaqmorarka
approved these changes
Jul 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support
COMMENT ON VIEWstatement in Hive & Iceberg connectorDocumentation
( ) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: