Describe adding insert support in a connector#13046
Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom Jul 27, 2022
Merged
Describe adding insert support in a connector#13046raunaqmorarka merged 2 commits intotrinodb:masterfrom
raunaqmorarka merged 2 commits intotrinodb:masterfrom
Conversation
findinpath
reviewed
Jul 1, 2022
nineinchnick
force-pushed
the
dev-guide-insert
branch
from
66882aa to
d1aacf5
Compare
nineinchnick
added
the
no-release-notes
mosabua
requested changes
Jul 26, 2022
Member
There was a problem hiding this comment.
Suggested change
| connector specific information and will be passed to the page sink provider. | |
| connector specific information, and it is passed to the page sink provider. |
Member
Author
There was a problem hiding this comment.
I forgot about using the present tense, but I wanted to ask about passive voice - is it is passed passive and should we change it to say that the eng^H^H^H Trino passes it?
nineinchnick
force-pushed
the
dev-guide-insert
branch
from
d1aacf5 to
45698f6
Compare
Member
Author
|
@mosabua ready for another round, I also ran the Vale linter on this and it found one extra space :D |
mosabua
reviewed
Jul 26, 2022
mosabua
approved these changes
Jul 26, 2022
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
One nit but essentially good to go.
nineinchnick
force-pushed
the
dev-guide-insert
branch
from
45698f6 to
68496a3
Compare
nineinchnick
force-pushed
the
dev-guide-insert
branch
from
68496a3 to
c736788
Compare
martint
reviewed
Jul 27, 2022
| write deletions and/or updates to the underlying data store. | ||
| * The connector's ``UpdatablePageSource.getNextPage()`` implementation fetches the next page | ||
| from the underlying ``ConnectorPageSource``, optionally reformats the page, and returns it | ||
| from the underlying ``ConnectorPageSource``, optionally rebuild the page, and returns it |
|
|
||
| When executing an ``INSERT`` statement, the engine calls the ``beginInsert()`` | ||
| method in the connector, which receives a table handle and a list of columns. | ||
| It should return a ``ConnectorInsertTableHandle``, that can carry any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues, pull requests, and links
ConnectorPageSinkProvideris also briefly described in Dev guide connector features #12956, it could link to this page or maybe since it's short we should merge these two PRs. OTOH we might expand this more by adding examples on how to iterate over aPage, handle transactions, delayed writes, etc.Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: