Dev guide connector features#12956
Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom Jul 22, 2022
Merged
Conversation
nineinchnick
commented
Jun 24, 2022
nineinchnick
added
the
no-release-notes
nineinchnick
force-pushed
the
dev-guide-connector-features
branch
from
621771d to
e056593
Compare
This was referenced Jun 28, 2022
Member
There was a problem hiding this comment.
Can also mention Dynamic filter here as that is a type of pushdown that needs to be explicitly implemented by the connector
Member
Author
There was a problem hiding this comment.
This section is specifically about ConnectorMetadata. I'd describe dynamic filtering in a follow-up PR and then I can reference it here.
MiguelWeezardo
approved these changes
Jul 5, 2022
Member
|
I have nothing to add after @raunaqmorarka's comments |
nineinchnick
force-pushed
the
dev-guide-connector-features
branch
from
e056593 to
188cf2f
Compare
nineinchnick
force-pushed
the
dev-guide-connector-features
branch
from
188cf2f to
fcd5961
Compare
Member
Author
|
@mosabua PTAL |
raunaqmorarka
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the developer guide to:
ConnectorRecordSetProviderorConnectorPageSourceProviderhas to be implementedConnectorPageSinkProviderListing all features, even without describing them in detail, might help developers know what to look for in the interface classes' source code.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: