Skip to content

Enable Error Prone check: HidingField #12724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Jun 7, 2022
Merged

Enable Error Prone check: HidingField #12724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions plugin/trino-bigquery/src/test/java/io/trino/plugin/bigquery/BigQueryTestView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@
public class BigQueryTestView
extends TestTable
{
private final SqlExecutor sqlExecutor;
private final TestTable table;
private final String viewName;

public BigQueryTestView(SqlExecutor sqlExecutor, TestTable table)
{
super(sqlExecutor, table.getName(), null);
this.sqlExecutor = requireNonNull(sqlExecutor, "sqlExecutor is null");
this.table = requireNonNull(table, "table is null");
this.viewName = table.getName() + "_view";
}
Expand Down
3 changes: 0 additions & 3 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseSharedMetastoreTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
import io.trino.testing.AbstractTestQueryFramework;
import org.testng.annotations.Test;

import java.nio.file.Path;

import static io.trino.testing.sql.TestTable.randomTableSuffix;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
Expand All @@ -27,7 +25,6 @@ public abstract class BaseSharedMetastoreTest
extends AbstractTestQueryFramework
{
protected final String schema = "test_shared_schema_" + randomTableSuffix();
protected Path dataDirectory;

protected abstract String getExpectedHiveCreateSchema(String catalogName);

Expand Down
3 changes: 3 additions & 0 deletions plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSharedHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
import io.trino.tpch.TpchTable;
import org.testng.annotations.AfterClass;

import java.nio.file.Path;

import static io.trino.plugin.iceberg.IcebergQueryRunner.ICEBERG_CATALOG;
import static io.trino.plugin.tpch.TpchMetadata.TINY_SCHEMA_NAME;
import static io.trino.testing.QueryAssertions.copyTpchTables;
Expand All @@ -44,6 +46,7 @@ public class TestSharedHiveMetastore
extends BaseSharedMetastoreTest
{
private static final String HIVE_CATALOG = "hive";
private Path dataDirectory;

@Override
protected QueryRunner createQueryRunner()
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,6 +1898,7 @@
-Xep:EqualsIncompatibleType:ERROR \
-Xep:FallThrough:ERROR \
-Xep:GuardedBy:OFF <!-- needs some careful inspection --> \
-Xep:HidingField:ERROR \
-Xep:ImmutableEnumChecker:OFF <!-- flags enums with List fields even if initialized with ImmutableList, and other false positives --> \
-Xep:ImmutableSetForContains:ERROR \
-Xep:InconsistentCapitalization:ERROR <!-- fields/variables should not differ only in case --> \
Expand Down